Associate value with isTrue/isFalse criteria operators
#1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now associate a boolean value with both operators as those operators are rendered using equals comparison in the actual SQL text.
Reduce test method visibility.
|
I'd like to have an integration test for this because the past has shown that not all databases properly understand booleans. |
|
There is one in place, see |
schauder
reviewed
Mar 1, 2022
| @@ -427,19 +440,44 @@ void mapQueryForEnumArrayShouldMapToStringList() { | |||
| assertThat(bindings.getCondition()).hasToString("person.enum_value IN (?[$1], ?[$2])"); | |||
| } | |||
|
|
|||
| @Test // gh-733 | |||
There was a problem hiding this comment.
These test are in the R2DBC part, but the changes are for JDBC.
There was a problem hiding this comment.
Actually, the changes are in Relational but we don't have a query mapper for Spring Data Relational and we never ensured in R2DBC how isTrue is bound in R2DBC. The JDBC counterpart should be in #908.
The changes in the Criteria API are now covered with additional assertions and the JDBC change went into effect with #908.
schauder
pushed a commit
that referenced
this pull request
Mar 1, 2022
We now associate a boolean value with both operators as those operators are rendered using equals comparison in the actual SQL text. Orginal pull request #1188
schauder
pushed a commit
that referenced
this pull request
Mar 1, 2022
Reduce test method visibility. Orginal pull request #1188
schauder
pushed a commit
that referenced
this pull request
Mar 1, 2022
We now associate a boolean value with both operators as those operators are rendered using equals comparison in the actual SQL text. Orginal pull request #1188
schauder
pushed a commit
that referenced
this pull request
Mar 1, 2022
Reduce test method visibility. Orginal pull request #1188
|
Merged and ported to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now associate a boolean value with both operators as those operators are rendered using equals comparison in the actual SQL text.
Should be also backported to
main.Related issue: spring-projects/spring-data-r2dbc#733