GH-821 Add support for specifying ORDER BY null handling for supported dialects #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
schauder
requested changes
Feb 4, 2022
...ata-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/SqlGeneratorUnitTests.java
Outdated
Show resolved
Hide resolved
...ata-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/SqlGeneratorUnitTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/data/jdbc/core/JdbcAggregateTemplateIntegrationTests.java
Show resolved
Hide resolved
...lational/src/main/java/org/springframework/data/relational/core/dialect/AbstractDialect.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupport.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupport.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupported.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupported.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupported.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/data/relational/core/dialect/OrderByOptionsSupported.java
Outdated
Show resolved
Hide resolved
mipo256
reviewed
Feb 4, 2022
| * @author Chirag Tailor | ||
| */ | ||
| public interface OrderByOptionsSupport { | ||
| String resolve(@Nullable Sort.Direction direction, Sort.NullHandling nullHandling); |
There was a problem hiding this comment.
I also think this function lacks documentation. It is not clear from the first glance, ( at leas for me :) ) what exactly resolve function does. Maybe we can add javadoc upon it? @ctailor2 Chirag, what do you think?
There was a problem hiding this comment.
Agreed @mikhail2048, it wasn't very clear and I think that is largely because the two related but distinct concepts of Sort.Direction and Sort.NullHandling shouldn't be coupled together here. I moved the direction handling back out and and repurposed this interface to be for Sort.NullHandling only which hopefully makes the code more clear. I also added some more javadocs. Could you review my latest changes to see if these updates improve upon this?
Move ORDER BY direction evaluation back into OrderByClauseVisitor.
This makes the implementation more explicit and resilient to possible upstream code changes.
…s conform than do not.
|
Thanks. That's polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying how null values should be handled when ordering query results, via the
NULLS FIRSTandNULLS LASToptions, for stores conforming to the SQL standard.Dialects for which null handling support was added:
Dialects with no current support for null handling:
Closes #821