Skip to content

GH-1046 Convert Collection Elements to Target Type #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

ctailor2
Copy link
Contributor

This fixes an issue where the element type information for an entity's target property was being lost before the conversion takes place.

Closes #1046

@ctailor2 ctailor2 requested a review from schauder January 27, 2022 14:46
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 27, 2022
schauder pushed a commit that referenced this pull request Jan 31, 2022
This is achieved by passing the full availabe type information of the conversion target to the conversion service.

This broke a test which wasn't functional in the first place which becomes obvious when adding the proper assertion.

Closes #1046
Original pull request #1144
schauder added a commit that referenced this pull request Jan 31, 2022
@schauder
Copy link
Contributor

Thanks for the fix. Nice solution and good finding that broken test.

This is merged.

@schauder schauder closed this Jan 31, 2022
schauder added a commit that referenced this pull request Jan 31, 2022
See #1046
Original pull request #1144
schauder pushed a commit that referenced this pull request Feb 15, 2022
This is achieved by passing the full availabe type information of the conversion target to the conversion service.

This broke a test which wasn't functional in the first place which becomes obvious when adding the proper assertion.

Closes #1046
Original pull request #1144
schauder added a commit that referenced this pull request Feb 15, 2022
schauder added a commit that referenced this pull request Feb 15, 2022
See #1046
Original pull request #1144
@schauder schauder deleted the issue/1046-support-pg-float-arrays branch March 1, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support float[] for Postgres
3 participants