Skip to content

Solving Issue/datajdbc-1099 #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Solving Issue/datajdbc-1099 #1108

wants to merge 2 commits into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Dec 4, 2021

This PR fFixes #1099 bug. Jens @schauder, can you, please, review these changes?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 4, 2021
schauder pushed a commit that referenced this pull request Dec 7, 2021
schauder added a commit that referenced this pull request Dec 7, 2021
Removed jetbrains annotation.
Removed attempt to cache annotation lookup.
Those lookups are already cached and obtaining them in the constructor causes overhead when they aren't requested at all.
Limit the use of Optional.

See #1099
Original pull request #1108
@schauder
Copy link
Contributor

schauder commented Dec 7, 2021

Thanks, that's polished and merged.

@schauder schauder closed this Dec 7, 2021
@schauder schauder self-assigned this Dec 7, 2021
@vab2048
Copy link

vab2048 commented Apr 28, 2022

Did this eventually actually get merged? I still cannot see a schema parameter for the @Table annotation. This would make specifying the schema much easier.

@ZeroOne3010
Copy link

@vab2048 It is there now: 😃

/**
* Name of the schema (or user, for example in case of oracle), in which this table resides in
* The behavior is the following: <br/>
* If the {@link Table#schema()} is specified, then it will be
* used as a schema of current table, i.e. as a prefix to the name of the table, which can
* be specified in {@link Table#value()}. <br/>
* If the {@link Table#schema()} is not specified, then spring data will assume the default schema,
* The default schema itself can be provided by the means of {@link NamingStrategy#getSchema()}
*/
String schema() default "";

I'm also eagerly awaiting a release with this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants