Skip to content

SimpleCondion npe bug fix #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

githubyong
Copy link

@githubyong githubyong commented Aug 24, 2021

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@githubyong Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 24, 2021
@pivotal-cla
Copy link

@githubyong Thank you for signing the Contributor License Agreement!

@githubyong
Copy link
Author

fix for #1034

@schauder schauder linked an issue Aug 25, 2021 that may be closed by this pull request
@schauder
Copy link
Contributor

schauder commented Aug 25, 2021

Thanks for looking into the issue but filtering the null elements is not the correct strategy. Instead no value in that place should be null in the first place. Also a change in behaviour should be accompanied by a test.

@schauder schauder closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is SimpleCondition available?
4 participants