Skip to content

Update MyBatis dependencies [DATAJDBC-191] #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Mar 26, 2018 · 0 comments
Closed

Update MyBatis dependencies [DATAJDBC-191] #422

spring-projects-issues opened this issue Mar 26, 2018 · 0 comments
Assignees
@schauder
Labels
type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Jens Schauder opened DATAJDBC-191 and commented

Referenced from: pull request #55, and commits ce020a4
@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de
#421 - Suppress results for suspended query methods returning kotlin.…
4f04c87 
…Unit.

We now discard results for suspended query methods if the return type is kotlin.Unit.

Related ticket: DATACMNS-1779

Original pull request: #422.
mp911de pushed a commit that referenced this issue Feb 21, 2022
@ada-waffles @mp911de
#421 - Handle modifying query methods returning kotlin.Unit.
748d6c3 
Added check for kotlin.Unit to AbstractR2dbcQuery#getExecutionToWrap. This case is essentially equivalent to a return type of Void, but the singleton Unit instance needs to be returned instead of discarding the result entirely.

It was also necessary to add a check to R2dbcQueryMethod#getEntityInformation, as otherwise a PersistentEntity is created for Unit, which leads to a new instance being created via reflection down the pipeline (which is probably not a thing that should happen).

Original pull request: #422.
mp911de added a commit that referenced this issue Feb 21, 2022
@mp911de
#421 - Polishing.
2f9ca57 
Simplify tests. Use ReflectionUtils.isVoid(…) where possible and simplify isVoid(…) flows.

Original pull request: #422.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schauder @spring-projects-issues