Skip to content

JdbcAggregateTemplate not triggering AfterConvertCallback for all query methods #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
micopiira opened this issue Jan 10, 2025 · 1 comment
Closed

JdbcAggregateTemplate not triggering AfterConvertCallback for all query methods #1979

micopiira opened this issue Jan 10, 2025 · 1 comment
Assignees
@schauder
Labels
type: bug A general bug
Milestone
3.3.8 (2024.0.8)

Comments

@micopiira
Copy link

To me it seems that the following query methods do not trigger AfterConvertCallback even though I expect them to do so:

JdbcAggregateTemplate#findOne(org.springframework.data.relational.core.query.Query, java.lang.Class<T>)
JdbcAggregateTemplate#findAll(org.springframework.data.relational.core.query.Query, java.lang.Class<T>)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 10, 2025
@schauder schauder self-assigned this Jan 13, 2025
@schauder schauder added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2025
schauder added a commit that referenced this issue Jan 13, 2025
@schauder
Invoke callbacks for find by Query methods.
1c9c014 
Callback handlers are now properly called for findAll/One with Query parameter.

Closes #1979
schauder added a commit that referenced this issue Jan 13, 2025
@schauder
Invoke callbacks for find by Query methods.
f7462c4 
Callback handlers are now properly called for findAll/One with Query parameter.

Closes #1979
@schauder schauder added this to the 3.3.8 (2024.0.8) milestone Jan 13, 2025
@schauder
Copy link
Contributor

Thanks for finding and reporting this.
It's fixed for the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: bug A general bug
Projects
None yet
Milestone
3.3.8 (2024.0.8)
Development

No branches or pull requests
3 participants
@schauder @micopiira @spring-projects-issues