Skip to content

Contradictory documentation in BeforeConvertCallback #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbossi opened this issue Nov 18, 2023 · 0 comments
Closed

Contradictory documentation in BeforeConvertCallback #1673

cbossi opened this issue Nov 18, 2023 · 0 comments
Assignees
Labels
type: task A general task

Comments

@cbossi
Copy link

cbossi commented Nov 18, 2023

In the topmost section of the documentation of BeforeConvertCallback it is written:

The decision if the change will be an insert or update is made after this callback gets called.

This is contradictory to the points (1) and (2) in bullet points right below describing the persistence process.

Due to the fact that BeforeConvertCallback can be used to create Id values for new aggregates I think the bullet points are correct and the introductory sentence should be changed to

The decision if the change will be an insert or update is made before this callback gets called.

This would also be in line with the documentation of BeforeConvertEvent, which states:

Gets published before an aggregate gets converted into a database change, but after the decision was made if an insert or an update is to be performed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 18, 2023
schauder added a commit that referenced this issue Nov 21, 2023
schauder added a commit that referenced this issue Nov 21, 2023
schauder added a commit that referenced this issue Nov 21, 2023
@schauder schauder added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2023
@schauder schauder self-assigned this Nov 21, 2023
@schauder schauder added this to the 3.1.7 (2023.0.7) milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants