-
Notifications
You must be signed in to change notification settings - Fork 358
Reinstate support for mariadb-r2dbc #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's correct, as there is no 1.0-compliant version of the MariaDB driver. |
@mp911de Do you know if there's an issue to track for the 1.0-compliant version? Also, what library are you referring to as 1.0? |
1.0 refers to the R2DBC specification version in this context, apologies for ambiguity. MariaDB is stuck on version 0.9 of the R2DBC spec. Upgrading to R2DBC 1.0 doesn't require much of a change, however, the changes are binary incompatible in comparison to 0.9.x. |
Thanks for the details y'all! |
mariadb-r2dbc should be r2dbc 1.0 compliant now. |
We can do so once the artifact is available from Maven Central. |
It should be already https://mvnrepository.com/artifact/org.mariadb/r2dbc-mariadb/1.1.3. |
For Spring Boot, please file a ticket at https://github.com/spring-projects/spring-boot/issues. Meanwhile, we're going to reinstate our test support. |
Thanks @mp911de. |
spring-data-r2dbc used to depend on r2dbc bom:
https://github.com/spring-projects/spring-data-r2dbc/blob/e8ba67be6b35d147b5d10ec02bff81a12da75db2/pom.xml#L69-L75
which manages r2dbc-mariadb:
https://github.com/r2dbc/r2dbc-bom/blob/03ff2d7b854d2f162952c5705f2630faf4c501b4/pom.xml#L79-L83
As of version 3.0.0-RC1, r2dbc-mariadb is not managed:
spring-data-relational/spring-data-r2dbc/pom.xml
Lines 201 to 236 in 04aacd8
Is this a bug or a design decision?
The text was updated successfully, but these errors were encountered: