Dependencies go in wrong direction between sql.render and dialect. #1105
Milestone
Comments
schauder
added a commit
that referenced
this issue
Dec 1, 2021
Simplified the code structure. Ensured backward compatibility by recreating some methods often immediately deprecating them. Moved new classes to the places where they belong, so that the package ...core.sql.render depends on ...core.dialect and not the other way round. This causes dependency cycles because dependencies in the other direction already exists. This will be properly fixed by #1105. For now the offending classes are ignored by the DependencyTests. See #777 See #1105 Polishing
schauder
added a commit
that referenced
this issue
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dialect must not depend on sql.render, but currently does. This lead to dependency cycles when implementing #777.
The fix requires moving classes to different packages which would break backward compatibility.
Therefore this should be fixed for 3.0.
The text was updated successfully, but these errors were encountered: