Skip to content

Resolve package cycle between dialect and convert packages #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Sep 30, 2021 · 2 comments
Closed

Resolve package cycle between dialect and convert packages #1062

mp911de opened this issue Sep 30, 2021 · 2 comments
Labels
type: task A general task
Milestone
3.0 M1 (2022.0.0)

Comments

@mp911de
Copy link
Member

mp911de commented Sep 30, 2021

Logically, the entity converters need to consider dialect specifics. Dialects pull in simple type converters (e.g. JSR 310 Timestamp converters) and create a cycle. Additionally, Dialects should operate with JDBCValue but JDBCValue is a type from the convert package. We should resolve this cycle by relocating simple converters into org.springframework.jdbc.core.convert and JDBCValue should move into the support package.
@mp911de mp911de added the type: task A general task label Sep 30, 2021
@mp911de mp911de added this to the 3.x milestone Sep 30, 2021
@schauder
Copy link
Contributor

If JDBCValue is in a spring data support package we get a dependency from framework to data. I don't like that too much. I still think we should find a place under o.sf.data for our converters.

@schauder
Copy link
Contributor

Fixed by #1128 and related commits on 3.0.x

schauder added a commit that referenced this issue Jan 14, 2022
@schauder
Moved JdbcValue
07cef3f 
This avoids cyclic dependencies between mapping and conversion.

Closes #1062
See #1128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.0 M1 (2022.0.0)
Development

No branches or pull requests
2 participants
@schauder @mp911de