Skip to content

Create support for QueryLookupStrategy in @EnableJdbcRepositories #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mipo256 opened this issue Sep 10, 2021 · 1 comment
Closed

Create support for QueryLookupStrategy in @EnableJdbcRepositories #1043

mipo256 opened this issue Sep 10, 2021 · 1 comment
Labels
type: enhancement A general enhancement

Comments

@mipo256
Copy link
Contributor

mipo256 commented Sep 10, 2021

In accordance to the documentation there should be annotation parameter, called queryLookupStrategy, which indicates the strategy of how exactly spring data will derive queries for methods. It is present in EnableMongoRepositories, also in EnableJpaRepositories. But why there is no such thing in spring data jdbc? It would be helpful.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 10, 2021
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 10, 2021
@DiegoKrupitza
Copy link
Contributor

I can take a closer look at this issue.

DiegoKrupitza added a commit to DiegoKrupitza/spring-data-jdbc that referenced this issue Feb 24, 2022
@DiegoKrupitza
Introduced queryLookupStrategy to EnableJdbcRepositories.
ca00d31 
Added the missing functionality that is found in the documentation of spring-data-jdbc, but was not present in the code as functionality. Users can not choose between various QueryLookupStrategies.

Closes spring-projects#1043
@DiegoKrupitza DiegoKrupitza mentioned this issue Feb 24, 2022
Closed
4 tasks
schauder added a commit that referenced this issue Mar 7, 2022
@schauder
Polishing.
b4d3838 
Run tests only for a single database since it is actually not testing anything database related.

Formatting.

Original pull request #1187
See #1043
schauder pushed a commit that referenced this issue Mar 7, 2022
@DiegoKrupitza @schauder
Introduced queryLookupStrategy to EnableJdbcRepositories.
246343f 
Added the missing functionality that is found in the documentation of spring-data-jdbc, but was not present in the code as functionality. Users can not choose between various QueryLookupStrategies.

Closes #1043
Original pull request #1187
schauder added a commit that referenced this issue Mar 7, 2022
@schauder
Polishing.
325d9cc 
Run tests only for a single database since it is actually not testing anything database related.

Formatting.

Original pull request #1187
See #1043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduced queryLookupStrategy to @EnableJdbcRepositories. DiegoKrupitza/spring-data-jdbc
4 participants
@schauder @spring-projects-issues @DiegoKrupitza @mipo256