Skip to content

DATAREDIS-1035 - Fix confusing/incorrect JavaDoc of RedisKeyExpiredEvent #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

efdknittlfrank
Copy link
Contributor

The JavaDoc of RedisKeyExpiredEvent used the phrase "must not", when it should say "does not have to" or "need not". Rephrase the JavaDoc to be less confusing to native speakers.

@pivotal-issuemaster
Copy link

@efdknittlfrank Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@efdknittlfrank
Copy link
Contributor Author

I consider this an "obvious fix" as described in the "about" section of the CLA FAQ:

In certain cases described below, Pivotal may accept very minor contributions without requiring a CLA. This is designed for contributions that are minor enough (e.g. spelling errors, grammar mistakes, typos, formatting mistakes, etc.) to not be considered by you to be intellectual property that is independently protectable (an “Obvious Fix”).

@mp911de
Copy link
Member

mp911de commented Sep 25, 2019

No need to sign the CLA. @pivotal-issuemaster this is an obvious fix

@pivotal-issuemaster
Copy link

@efdknittlfrank This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@mp911de mp911de changed the title Fix confusing/incorrect JavaDoc of RedisKeyExpiredEvent DATAREDIS-1035 - Fix confusing/incorrect JavaDoc of RedisKeyExpiredEvent Sep 25, 2019
mp911de pushed a commit that referenced this pull request Sep 25, 2019
mp911de added a commit that referenced this pull request Sep 25, 2019
Tweak Javadoc wording. Add missing Javadoc tag documentation.

Original pull request: #478.
mp911de pushed a commit that referenced this pull request Sep 25, 2019
mp911de added a commit that referenced this pull request Sep 25, 2019
Tweak Javadoc wording. Add missing Javadoc tag documentation.

Original pull request: #478.
@mp911de
Copy link
Member

mp911de commented Sep 25, 2019

Thanks a lot, that's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants