-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DATAREDIS-1013 - Fix wrong argument count for SELECT command #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Redis SELECT command requires a single argument.
@svolle Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@svolle Thank you for signing the Contributor License Agreement! |
I could not reproduce the test failure in my dev environment and the failed test does not seem related in any way with my change. It looks like a spurious failure to me. |
No worries. Some tests include kind-of invisible latency or timing assumptions that fail when the CI system is slow. |
Can you also provide a test that shows the change is working via |
Sure. Can I assume a redis server running on localhost for this test? It seems to be already the case for other tests. |
Yes, you can. You can start the test environment via |
Redis SELECT command requires a single argument. Original pull request: #468.
Add test. Consider grammar depending on argument count. Original pull request: #468.
Redis SELECT command requires a single argument. Original pull request: #468.
Add test. Consider grammar depending on argument count. Original pull request: #468.
That's merged now. |
Thanks Mark. Should I create another PR when I eventually come around to add the UT you requested? |
I took care of the test during the merge. |
My bad, I did not see the new commits. Sorry for being a slowpoke and not taking care of this in a timely manner. Thanks! |
Redis SELECT command requires a single argument.