Skip to content

DATAREDIS-1013 - Fix wrong argument count for SELECT command #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

svolle
Copy link
Contributor

@svolle svolle commented Jul 11, 2019

Redis SELECT command requires a single argument.

Redis SELECT command requires a single argument.
@pivotal-issuemaster
Copy link

@svolle Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@svolle Thank you for signing the Contributor License Agreement!

@svolle
Copy link
Contributor Author

svolle commented Jul 12, 2019

I could not reproduce the test failure in my dev environment and the failed test does not seem related in any way with my change. It looks like a spurious failure to me.

@mp911de
Copy link
Member

mp911de commented Jul 12, 2019

No worries. Some tests include kind-of invisible latency or timing assumptions that fail when the CI system is slow.

@mp911de
Copy link
Member

mp911de commented Jul 12, 2019

Can you also provide a test that shows the change is working via RedisCommands.execute(…)?

@svolle
Copy link
Contributor Author

svolle commented Jul 12, 2019

Sure. Can I assume a redis server running on localhost for this test? It seems to be already the case for other tests.

@mp911de
Copy link
Member

mp911de commented Jul 12, 2019

Yes, you can. You can start the test environment via make start. Alternatively, $ redis-server (using default config) should be fine. Thanks a lot.

mp911de pushed a commit that referenced this pull request Jul 26, 2019
Redis SELECT command requires a single argument.

Original pull request: #468.
mp911de added a commit that referenced this pull request Jul 26, 2019
Add test. Consider grammar depending on argument count.

Original pull request: #468.
mp911de pushed a commit that referenced this pull request Jul 26, 2019
Redis SELECT command requires a single argument.

Original pull request: #468.
mp911de added a commit that referenced this pull request Jul 26, 2019
Add test. Consider grammar depending on argument count.

Original pull request: #468.
@mp911de
Copy link
Member

mp911de commented Jul 26, 2019

That's merged now.

@mp911de mp911de closed this Jul 26, 2019
@svolle
Copy link
Contributor Author

svolle commented Jul 26, 2019

Thanks Mark. Should I create another PR when I eventually come around to add the UT you requested?

@mp911de
Copy link
Member

mp911de commented Jul 26, 2019

I took care of the test during the merge.

@svolle
Copy link
Contributor Author

svolle commented Jul 26, 2019

My bad, I did not see the new commits. Sorry for being a slowpoke and not taking care of this in a timely manner.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants