Skip to content

Using getRequiredAdapter in RedisQueryEngine to avoid NPE. #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Using getRequiredAdapter in RedisQueryEngine to avoid NPE. #2801

wants to merge 1 commit into from

Conversation

junghoon-vans
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes: #2800

@junghoon-vans junghoon-vans changed the title Use getRequiredAdapter to avoid NPE. Using getRequiredAdapter in RedisQueryEngine to avoid NPE. Dec 11, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 11, 2023
@mp911de mp911de added this to the 3.1.7 (2023.0.7) milestone Dec 11, 2023
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 11, 2023
mp911de pushed a commit that referenced this pull request Dec 11, 2023
@junghoon-vans @mp911de
Refine getRequiredAdapter()usage in RedisQueryEngine.
4e5aabf 
We now use getRequiredAdapter() instead of getAdapter() to enforce either an object or a proper exception.

Closes #2800
Original pull request: #2801
mp911de pushed a commit that referenced this pull request Dec 11, 2023
@junghoon-vans @mp911de
Refine getRequiredAdapter()usage in RedisQueryEngine.
844d236 
We now use getRequiredAdapter() instead of getAdapter() to enforce either an object or a proper exception.

Closes #2800
Original pull request: #2801
mp911de pushed a commit that referenced this pull request Dec 11, 2023
@junghoon-vans @mp911de
Refine getRequiredAdapter()usage in RedisQueryEngine.
3ad3874 
We now use getRequiredAdapter() instead of getAdapter() to enforce either an object or a proper exception.

Closes #2800
Original pull request: #2801
@mp911de
Copy link
Member

mp911de commented Dec 11, 2023

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.1.7 (2023.0.7)
Development

Successfully merging this pull request may close these issues.

Using getRequiredAdapter in RedisQueryEngine to avoid NPE
3 participants
@junghoon-vans @mp911de @spring-projects-issues