Skip to content

Remove outdated CI docs #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

junghoon-vans
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

closes: #2766

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 10, 2023
@mp911de
Copy link
Member

mp911de commented Nov 10, 2023

I think we would want to remove the CI docs as it doesn't add much benefit for our community. For ourselves, we have documented the requirements in Jenkinsfile and the actual versions are stored in pipeline.properties.

@junghoon-vans
Copy link
Contributor Author

I think removing CI documentation completely makes it harder for community contributors to understand how to test locally.

mp911de added a commit that referenced this pull request Nov 10, 2023
Remove outdated CI documentation as the docs are in our Jenkinsfile.

Closes #2767
@mp911de mp911de closed this in 1082d31 Nov 10, 2023
@mp911de mp911de removed the status: waiting-for-triage An issue we've not yet triaged label Nov 10, 2023
@mp911de mp911de changed the title Update CI.adoc to support JDK 17. Remove outdated CI docs Nov 10, 2023
@mp911de mp911de added the type: documentation A documentation update label Nov 10, 2023
@mp911de mp911de added this to the 3.1.6 (2023.0.6) milestone Nov 10, 2023
@mp911de
Copy link
Member

mp911de commented Nov 10, 2023

Good point. I was under the impression that the readme mentions make but it is only showing mvn clean install. Let me update the docs for that aspect.

@junghoon-vans
Copy link
Contributor Author

Great, I see your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI documentation is outdated
3 participants