Use pattern matching instead of type casting #2754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
junghoon-vans
commented
Oct 23, 2023
junghoon-vans
commented
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
spring-projects-issues
added
the
status: waiting-for-triage
junghoon-vans
force-pushed
the
use-pattern-matching-instead-of-type-casting
branch
3 times, most recently
from
ac3cad2 to
7e88382
Compare
mp911de
added
type: task
jxblum
reviewed
Oct 24, 2023
src/main/java/org/springframework/data/redis/connection/jedis/JedisConverters.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/IndexWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/RedisKeyValueAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/convert/DefaultRedisTypeMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/convert/MappingRedisConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/script/DefaultScriptExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/script/DefaultScriptExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/core/script/ScriptUtils.java
Outdated
Show resolved
Hide resolved
junghoon-vans
force-pushed
the
use-pattern-matching-instead-of-type-casting
branch
from
7e88382 to
b870f26
Compare
|
@jxblum Thank you. I've made all the changes as you suggested. |
junghoon-vans
force-pushed
the
use-pattern-matching-instead-of-type-casting
branch
from
b870f26 to
045ee24
Compare
|
Thank you for your contribution. That's merged, polished, and backported now. I refined some of the names to reduce names to the significant part and to de-duplicate names as we don't need to repeat ourselves within a particular context. |
mp911de
added a commit
that referenced
this pull request
Oct 27, 2023
Tweak naming. Simplify converters by removing unused methods. See #2754
mp911de
pushed a commit
that referenced
this pull request
Oct 27, 2023
mp911de
added a commit
that referenced
this pull request
Oct 27, 2023
Tweak naming. Simplify converters by removing unused methods. See #2754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.