Skip to content

Support for approximate and MINID trimming in XAddOptions and AddStreamRecord #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support for approximate and MINID trimming in XAddOptions and AddStreamRecord #2247

wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Jan 26, 2022 •
edited
Loading

for #2144 and closes #2228

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 26, 2022
@mp911de mp911de self-assigned this Mar 9, 2022
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 9, 2022
@mp911de mp911de mentioned this pull request Mar 9, 2022
Closed
@mp911de mp911de changed the title Support for approximate trimming in XAddOptions and AddStreamRecord Support for approximate and MINID trimming in XAddOptions and AddStreamRecord Mar 9, 2022
mp911de pushed a commit that referenced this pull request Mar 9, 2022
@dengliming @mp911de
Support for approximate trimming in XAddOptions and AddStreamRecord.
9b8bca6 
Closes #2247
mp911de added a commit that referenced this pull request Mar 9, 2022
@mp911de
Polishing.
d17e057 
Add support for MINID trimming. Add tests. Extract Jedis XAddParams conversion to StreamConverters.

Reorder methods. Simplify StreamRecord creation.

See #2247
@mp911de mp911de closed this in a3271f6 Mar 9, 2022
mp911de added a commit that referenced this pull request Mar 9, 2022
@mp911de
Polishing.
6b5e1c3 
Add support for MINID trimming. Add tests. Extract Jedis XAddParams conversion to StreamConverters.

Reorder methods. Simplify StreamRecord creation.

See #2247
@mp911de mp911de added this to the 2.7 M4 (2021.2.0) milestone Mar 9, 2022
@mp911de
Copy link
Member

mp911de commented Mar 9, 2022

Thank you for your contribution. That's merged and polished now.

@dengliming dengliming deleted the feature/xadd_approximateTrimming branch March 9, 2022 09:20
mp911de added a commit that referenced this pull request Mar 9, 2022
@mp911de
Polishing.
c63e2e2 
Add support for MINID trimming. Add tests. Extract Jedis XAddParams conversion to StreamConverters.

Reorder methods. Simplify StreamRecord creation.

See #2247
mp911de added a commit that referenced this pull request Mar 9, 2022
@mp911de
Polishing.
b87ef55 
Add support for MINID trimming. Add tests. Extract Jedis XAddParams conversion to StreamConverters.

Reorder methods. Simplify StreamRecord creation.

See #2247
@mp911de mp911de mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.7 M4 (2021.2.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@dengliming @mp911de @spring-projects-issues