Update RedisOperations#convertAndSend to return number of clients receiving the message.
#2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceiving the message. Currently, `RedisOperations#convertAndSend` is void event though the underlying `RedisPubSubCommands#publish` returns a `Long` that represents the number of clients receiving the published message (see https://redis.io/commands/publish). This commit updates `RedisOperations#convertAndSend` to return the number of clients that received the message. Closes spring-projects#2209
spring-projects-issues
added
the
status: waiting-for-triage
vpavic
commented
Jan 5, 2022
| // test no messages are sent just to patterns | ||
| template.convertAndSend(CHANNEL, payload1); | ||
| template.convertAndSend(ANOTHER_CHANNEL, payload2); | ||
| await().atMost(Duration.ofMillis(600)).untilAsserted(() -> { |
There was a problem hiding this comment.
I utilized Awaitility in use cases like this as it's more handy vs having to resort to Thread#sleep. Note that for this particular set of assertions I had to increase the grace period from 400 to 600 ms as the test was flaky, on my machine at least.
christophstrobl
added
theme: 4.0
type: enhancement
|
We're considering this change for the next Spring Data Redis 3.0 milestone. |
mp911de
pushed a commit
that referenced
this pull request
Mar 31, 2022
…eceiving the message. Currently, `RedisOperations#convertAndSend` is void event though the underlying `RedisPubSubCommands#publish` returns a `Long` that represents the number of clients receiving the published message (see https://redis.io/commands/publish). This commit updates `RedisOperations#convertAndSend` to return the number of clients that received the message. Closes #2209 Original pull request: #2225.
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
RedisOperations#convertAndSendis void event though the underlyingRedisPubSubCommands#publishreturns aLongthat represents the number of clients receiving the published message (see https://redis.io/commands/publish).This commit updates
RedisOperations#convertAndSendto return the number of clients that received the message.Closes #2209