Inconsistent key names in RENAME/RENAMENX command documentation
#2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
toddmerrill
commented
Nov 2, 2021
toddmerrill
commented
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
spring-projects-issues
added
the
status: waiting-for-triage
|
I also see the name 'oleName' in the classes StringRedisConnection, ReactiveKeyCommands and ReactiveRedisOperations. At the least I think they should be 'oldName', but is there a reason we don't use the same names for the parameters as Redis does? https://redis.io/commands/rename They use 'key' and 'newKey'. |
|
Thanks for the PR, I'm going to merge it. It would make sense to rename these for better precision in the documentation. |
mp911de
added
type: documentation
mp911de
changed the title
RENAME/RENAME
mp911de
changed the title
RENAME/RENAME RENAME/RENAME command documentation
mp911de
changed the title
RENAME/RENAME command documentationRENAME/RENAMENX command documentation
mp911de
added a commit
that referenced
this pull request
Nov 8, 2021
Rename key name arguments consistently to oldKey/newKey. See #2189
mp911de
pushed a commit
that referenced
this pull request
Nov 8, 2021
mp911de
added a commit
that referenced
this pull request
Nov 8, 2021
Rename key name arguments consistently to oldKey/newKey. See #2189
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.