-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add NOMKSTREAM
option to XADD
command
#2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I left a few comments, mostly highlevel aspects.
Also, you might want to update your email address used for the Git commits to connect these to your profile. Right now, the mail address in the Git commits doesn't match your Github profile.
Feel free to force-push all changes once you're done and leave a comment on the pull request once we should re-review.
src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java
Show resolved
Hide resolved
Hi @mp911de pushed changes to resolve comments. |
Thank you for your contribution. That's merged and polished now. |
Closes #2047