-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for BitFieldSubCommands that generate multiple bit operations using non-chaining methods #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ions using non-chaining methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of uncontrolled opening up the API, we should rather introduce factory methods with proper assertions, something like:
BitFieldGet.create(…)
that can be later on used with BitFieldSubCommands
through a BitFieldSubCommands.create(BitFieldSubCommand…)
and BitFieldSubCommands.create(Iterable<? extends BitFieldSubCommand>)
.
Thanks for the suggestion, I hadn't thought about it before, I'll submit a new pull later to improve it |
Feel free to either push additional commits onto your branch or force-push an amended commit. GitHub Pull requests automatically pick up your changes, so no need to create a new pull request. |
Thank you for your contribution. That's merged, polished, and backported now. |
resolves #2055