Skip to content

Add support for BitFieldSubCommands that generate multiple bit operations using non-chaining methods #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Yanam
Copy link
Contributor

@Yanam Yanam commented May 7, 2021

resolves #2055

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2021
@mp911de mp911de self-assigned this May 10, 2021
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of uncontrolled opening up the API, we should rather introduce factory methods with proper assertions, something like:

BitFieldGet.create(…)

that can be later on used with BitFieldSubCommands through a BitFieldSubCommands.create(BitFieldSubCommand…) and BitFieldSubCommands.create(Iterable<? extends BitFieldSubCommand>).

@Yanam
Copy link
Contributor Author

Yanam commented May 18, 2021

Instead of uncontrolled opening up the API, we should rather introduce factory methods with proper assertions, something like:

BitFieldGet.create(…)

that can be later on used with BitFieldSubCommands through a BitFieldSubCommands.create(BitFieldSubCommand…) and BitFieldSubCommands.create(Iterable<? extends BitFieldSubCommand>).

Thanks for the suggestion, I hadn't thought about it before, I'll submit a new pull later to improve it

@mp911de
Copy link
Member

mp911de commented May 18, 2021

Feel free to either push additional commits onto your branch or force-push an amended commit. GitHub Pull requests automatically pick up your changes, so no need to create a new pull request.

@Yanam Yanam requested a review from mp911de May 22, 2021 14:28
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 14, 2021
mp911de pushed a commit that referenced this pull request Jun 17, 2021
…ions using non-chaining methods.

Original pull request: #2060.
Closes #2055
mp911de added a commit that referenced this pull request Jun 17, 2021
Add since tags, equals/hashCode/toString methods. Reformat code.

Original pull request: #2060.
Closes #2055
mp911de pushed a commit that referenced this pull request Jun 17, 2021
…ions using non-chaining methods.

Original pull request: #2060.
Closes #2055
mp911de added a commit that referenced this pull request Jun 17, 2021
Add since tags, equals/hashCode/toString methods. Reformat code.

Original pull request: #2060.
Closes #2055
@mp911de
Copy link
Member

mp911de commented Jun 17, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 17, 2021
@mp911de mp911de added this to the 2.5.2 (2021.0.2) milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for BitFieldSubCommands that generate multiple bit operations using non-chaining methods
3 participants