Skip to content

Add support for COPY via RedisOperations #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for COPY via RedisOperations #2059

wants to merge 1 commit into from

Conversation

ihaohong
Copy link
Contributor

@ihaohong ihaohong commented May 4, 2021 •
edited
Loading

see #2040

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-issuemaster
Copy link

@ihaohong Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@ihaohong Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 4, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 10, 2021
@mp911de mp911de self-assigned this May 11, 2021
@mp911de
Copy link
Member

mp911de commented May 11, 2021

Thanks for your contribution. I'm going to pick it up from here.

@ihaohong
Copy link
Contributor Author

ihaohong commented Jun 7, 2021

Thanks for your contribution. I'm going to pick it up from here.

@mp911de Hi, could you please tell me when my code would be picked?

@mp911de mp911de linked an issue Jun 15, 2021 that may be closed by this pull request
Add support for COPY via RedisOperations and ReactiveRedisOperations #2040
Closed
@mp911de mp911de added this to the 2.6 M1 (2021.1.0) milestone Jun 15, 2021
mp911de pushed a commit that referenced this pull request Jun 15, 2021
@ihaohong @mp911de
Add support for COPY.
1a4eef3 
Closes #2040
Original pull request: #2059.
mp911de added a commit that referenced this pull request Jun 15, 2021
@mp911de
Polishing.
7cd0669 
Extend copy(…) command with replace argument. Add support for reactive copy(…). Fix connection unit tests. Reorder methods.

Add since tags.

See #2040
Original pull request: #2059.
@mp911de
Copy link
Member

mp911de commented Jun 15, 2021

Thank you for your contribution. That's merged and polished now. I added reactive support for COPY as part of the polishing commit. Sometimes merging a pull request takes a bit of time on our side as we can be busy with other things.

@mp911de mp911de closed this Jun 15, 2021
@ihaohong
Copy link
Contributor Author

ok, thanks polishing 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.6 M1 (2021.1.0)
Development

Successfully merging this pull request may close these issues.

Add support for COPY via RedisOperations and ReactiveRedisOperations
4 participants
@ihaohong @pivotal-issuemaster @mp911de @spring-projects-issues