Skip to content

Remove superfluous try catch blocks from Jedis*Commands #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove superfluous try catch blocks from Jedis*Commands #1960

wants to merge 5 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Feb 8, 2021

Remove superfluous try catch blocks from Jedis*Commands with JedisInvoker. Refactor Converters and JedisConverters to use less indirections and use lambdas/method references where possible.

Closes #1951

@mp911de
Prepare issue branch.
2abdc98
@mp911de
Initial draft of JedisInvoker.
5104413
@mp911de
Next batch of commands.
8be983c
@mp911de
Next batch of commands.
c8019fe
@mp911de
Refactor converters.
d046ca4 
Prefer lambda-style converters. Replace indirections via Converters API with method references.
@mp911de mp911de added in: jedis Jedis driver type: task A general task labels Feb 8, 2021
@mp911de mp911de changed the title Issue/1951 Remove superfluous try catch blocks from Jedis*Commands Feb 8, 2021
christophstrobl pushed a commit that referenced this pull request Feb 10, 2021
@mp911de @christophstrobl
Introduce JedisInvoker.
c7eef8f 
We now use JedisInvoker to call Jedis and Pipeline methods for synchronous, pipelining, and transactional execution models. JedisInvoker captures the method invocation as functional utility and allows conversion of results:

Long result = invoker.just(BinaryJedis::geoadd, MultiKeyPipelineBase:geoadd, key, point.getX(), point.getY(), member);

Closes #1951
Original Pull Request: #1960
christophstrobl pushed a commit that referenced this pull request Feb 10, 2021
@mp911de @christophstrobl
Refactor converters.
53ce848 
Prefer lambda-style converters. Replace indirections via Converters API with method references.

Original Pull Request: #1960
christophstrobl added a commit that referenced this pull request Feb 10, 2021
@christophstrobl
Move identityConverter to Converters.
362396b 
Move the no op identity converter to Converters and reuse those across the connection package.
Fix nullables and minor code format issues along the way.

See: #1951
Original Pull Request: #1960
@christophstrobl christophstrobl deleted the issue/1951 branch February 10, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees
No one assigned
Labels
in: jedis Jedis driver type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove superfluous try catch blocks from Jedis*Commands
2 participants
@mp911de @christophstrobl