-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refine and clarify operations in asynchronous caching implementation #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 17, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a variable with strongly typed parameters. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 17, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 17, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Edits and refines Javadoc. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Edits and refines Javadoc. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Edits and refines Javadoc. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Edits and refines Javadoc. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Oct 18, 2023
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a (functional) variable with strongly typed parameters. Edits and refines Javadoc. Original Pull Request: spring-projects#2717 Closes spring-projects#2743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See Issue #2650
See Original Pull Request #2717
Uses more descriptive names for operations, especially Reactive operations, by either calling a local, private method or introducing a variable with strongly typed parameters.
For example, this
Function<ReactiveRedisConnection, Mono<T>> commandExecution
is more readable and descriptive thanit -> Mono.fromCompletionStage(callback.apply(it))
buried in some ReactivePublisher
(e.g.Flux
) operation. Outside of the IDE (such as reading source in GitHub), I immediately know that "it
" is a Redis (Reactive) connection, that I am executing a Redis command and that I can safely assume I am getting back a Mono ofT
(the value returned from the "reactive" command execution).In some case (perhaps many cases) Reactive programming obscures the actions that are actually happening (such as looping until some condition is met), particularly in "concurrent" fashion, making the code more difficult to understand. Without, proper naming and organization, understanding is greatly diminished and even readability is compromised.
Edits Javadoc.
The text was updated successfully, but these errors were encountered: