Skip to content

Rename Function Lambda parameter to match command interface in (Default) ReactiveXxxOperations #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jxblum opened this issue Aug 3, 2023 · 0 comments
Closed

Rename Function Lambda parameter to match command interface in (Default) ReactiveXxxOperations #2658

jxblum opened this issue Aug 3, 2023 · 0 comments
Assignees
@jxblum
Labels
in: core Issues in core support type: task A general task
Milestone
3.1.3 (2023.0.3)

Comments

@jxblum
Copy link
Contributor

jxblum commented Aug 3, 2023

In all (Default) ReactiveXxxOperation interfaces used by ReactiveRedisTemplate, the (Redis) operation methods refer to their corresponding command interface as "connection" when passing the Function Lambda to the createMono(:Function<..>, Publisher<T>) or createFlux(:Function<..>, Publisher<T>) methods, which is not technically accurate, and confusing.

The Function Lambda expects an instance of reactive commands (e.g. ReactiveSetCommands in the (Default) ReactiveSetOperations interface), which is obtained from the ReactiveRedisConnection.
@jxblum jxblum changed the title Rename Lambda Function parameter to match command interface in ReactiveXxxOperations Rename Function Lambda parameter to match command interface in (Default) ReactiveXxxOperations Aug 3, 2023
@jxblum jxblum added type: task A general task in: core Issues in core support labels Aug 3, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Aug 3, 2023
@jxblum
Rename Function Lambda parameter to match command interface in (Defau…
1d63620 
…lt) ReactiveXxxOperations.

Cleanup compiler warning.

Fix unnatural line breaks.

Closes spring-projects#2658
@jxblum jxblum mentioned this issue Aug 3, 2023
Closed
@jxblum jxblum self-assigned this Aug 3, 2023
mp911de pushed a commit that referenced this issue Aug 7, 2023
@jxblum @mp911de
Rename Function Lambda parameter to match command interface in (Defau…
c7ded60 
…lt) ReactiveXxxOperations.

Cleanup compiler warning.

Fix unnatural line breaks.

Closes #2658
Original pull request: #2659
mp911de added a commit that referenced this issue Aug 7, 2023
@mp911de
Polishing.
b939613 
Use createMono/createFlux syntax instead of using the template for wrapper creation.

See #2658
Original pull request: #2659
@mp911de mp911de closed this as completed in 0073744 Aug 7, 2023
mp911de added a commit that referenced this issue Aug 7, 2023
@mp911de
Polishing.
0b32e7b 
Use createMono/createFlux syntax instead of using the template for wrapper creation.

See #2658
Original pull request: #2659
@mp911de mp911de added this to the 3.1.3 (2023.0.3) milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxblum jxblum

Labels
in: core Issues in core support type: task A general task
Projects
None yet
Milestone
3.1.3 (2023.0.3)
2 participants
@mp911de @jxblum