Skip to content

BoundingBox.getWidth() returns height value #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YevhenPalamarchuk opened this issue Mar 12, 2023 · 0 comments
Closed

BoundingBox.getWidth() returns height value #2526

YevhenPalamarchuk opened this issue Mar 12, 2023 · 0 comments
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
2.7.12 (2021.2.12)

Comments

@YevhenPalamarchuk
Copy link

spring-data-redis/src/main/java/org/springframework/data/redis/domain/geo/BoundingBox.java

Line 73 in 7e1746c

return height;

Please fix :
public Distance getWidth() { return this.height; }

to
public Distance getWidth() { return this.width; }
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 12, 2023
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 14, 2023
@remeio remeio mentioned this issue Apr 17, 2023
Closed
@mp911de mp911de changed the title BoundingBox getWidth() returns height value BoundingBox.getWidth() returns height value Apr 24, 2023
@mp911de mp911de assigned mp911de and unassigned jxblum Apr 24, 2023
mp911de added a commit that referenced this issue Apr 24, 2023
@mp911de
Fix BoundingBox.width return value.
fc9c4d4 
We now return the correct value.

Closes #2526
mp911de added a commit that referenced this issue Apr 24, 2023
@mp911de
Fix BoundingBox.width return value.
c5e389f 
We now return the correct value.

Closes #2526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.12 (2021.2.12)
Development

No branches or pull requests
4 participants
@mp911de @jxblum @spring-projects-issues @YevhenPalamarchuk