Skip to content

Support for scan in RedisTemplate #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lc77254 opened this issue Feb 15, 2022 · 1 comment
Closed

Support for scan in RedisTemplate #2260

lc77254 opened this issue Feb 15, 2022 · 1 comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Milestone
2.7 M4 (2021.2.0)

Comments

@lc77254
Copy link
Contributor

lc77254 commented Feb 15, 2022

Recently I use redis scan in my project. But I found that I can't use it in RedisTemplate directly and use RedisCallback instead. It was implemented in ReactiveRedisTemplate, is there any issue when implement it in RedisTemplate? If not, I would like to implement it.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 15, 2022
@mp911de
Copy link
Member

mp911de commented Feb 15, 2022

Thanks for reaching out. I think that mostly no one asked for this feature yet. A specialty with SCAN is that the underlying cursor requires a connection to work on so the connection must not be closed/released after the command (see DefaultSetOperations.scan(…) for example). Other than that, feel free to submit a pull request.

@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2022
@lc77254 lc77254 mentioned this issue Feb 17, 2022
Closed
4 tasks
@mp911de mp911de linked a pull request Feb 23, 2022 that will close this issue
Support for scan in RedisTemplate #2263
Closed
4 tasks
@mp911de mp911de changed the title Support for scan in RedisTemplate Support for scan in RedisTemplate Feb 23, 2022
@mp911de mp911de added this to the 2.7 M4 (2021.2.0) milestone Feb 23, 2022
mp911de pushed a commit that referenced this issue Feb 23, 2022
@lc77254 @mp911de
Support scan in RedisTemplate.
04165fb 
Closes #2260
Original pull request: #2263.
mp911de added a commit that referenced this issue Feb 23, 2022
@mp911de
Polishing.
e31d122 
Add since tags. Consistently document scan command with try-with-resources guidance. Use try-with-resources in tests.

See #2260
Original pull request: #2263.
mp911de added a commit that referenced this issue Feb 23, 2022
@mp911de
Polishing.
47f2254 
Add since tags. Consistently document scan command with try-with-resources guidance. Use try-with-resources in tests.

See #2260
Original pull request: #2263.
mp911de pushed a commit that referenced this issue Feb 24, 2022
@lc77254 @mp911de
Support scan in RedisTemplate.
c7f87ea 
Closes #2260
Original pull request: #2263.
mp911de added a commit that referenced this issue Feb 24, 2022
@mp911de
Polishing.
2706a53 
Add since tags. Consistently document scan command with try-with-resources guidance. Use try-with-resources in tests.

See #2260
Original pull request: #2263.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
2.7 M4 (2021.2.0)
Development

Successfully merging a pull request may close this issue.

Support for scan in RedisTemplate
3 participants
@mp911de @spring-projects-issues @lc77254