Skip to content

Rewrite conversion of top-level collections in MappingRedisConverter #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mp911de opened this issue Sep 16, 2021 · 0 comments
Open

Rewrite conversion of top-level collections in MappingRedisConverter #2168

mp911de opened this issue Sep 16, 2021 · 0 comments
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Sep 16, 2021

MappingRedisConverter.write(…) attempts to obtain an entity from the given object to later on decide how to serialize it (collection, map, …). PersistentEntity retrieval breaks if the type is encapsulated (e.g. Arrays.asList(…)). The code still attempts to obtain a keyspace and the identifier accessor.

We should generally avoid identifier, keyspace name, and TTL retrieval from a collection as collections do not have such a property.

@mp911de mp911de added the type: task A general task label Sep 16, 2021
@mp911de mp911de added this to the 3.x milestone Sep 16, 2021
mp911de added a commit that referenced this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant