Skip to content

Reference documentation shows usage of deprecated code #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imbf opened this issue Feb 14, 2021 · 0 comments
Closed

Reference documentation shows usage of deprecated code #1964

imbf opened this issue Feb 14, 2021 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: documentation A documentation update

Comments

@imbf
Copy link

imbf commented Feb 14, 2021

when looking at redis.adoc, I saw code like below.

@Configuration
class WriteToMasterReadFromReplicaConfiguration {

  @Bean
  public LettuceConnectionFactory redisConnectionFactory() {

    LettuceClientConfiguration clientConfig = LettuceClientConfiguration.builder()
      .readFrom(SLAVE_PREFERRED)
      .build();

    RedisStandaloneConfiguration serverConfig = new RedisStandaloneConfiguration("server", 6379);

    return new LettuceConnectionFactory(serverConfig, clientConfig);
  }
}

There is one issue in this code, which is that SLAVE_PREFERRED is deprecated

this has been changed to REPLICA_PREFERRED and i am going to modify this and send it as a PR to this repository

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 14, 2021
@mp911de mp911de linked a pull request Feb 15, 2021 that will close this issue
4 tasks
mp911de pushed a commit that referenced this issue Feb 19, 2021
Fix example to create an instance of the LettuceClientConfiguration type with the appropriate constant variable.

Closes #1964
Original pull request: #1966.
mp911de pushed a commit that referenced this issue Feb 19, 2021
Fix example to create an instance of the LettuceClientConfiguration type with the appropriate constant variable.

Closes #1964
Original pull request: #1966.
@mp911de mp911de changed the title update redis.adoc Reference documentation shows usage of deprecated code Feb 19, 2021
@mp911de mp911de added the type: documentation A documentation update label Feb 19, 2021
@mp911de mp911de added this to the 2.3.8 (Neumann SR8) milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: documentation A documentation update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants