Return AbstractRedisClient from LettuceConnectionFactory [DATAREDIS-1170]

[spring-projects-issues]

Ramsey Lubbat opened DATAREDIS-1170 and commented

The RedisClient created by LettuceConnectionFactory is private. It would be helpful to expose it by adding a public getter.

According to its own documentation:

RedisClient is an expensive resource. It holds a set of netty's io.netty.channel.EventLoopGroup's that use multiple threads. Reuse this instance as much as possible or share a ClientResources instance amongst multiple client instances.

There are some third party libraries that interface with RedisClient. In projects using spring-data-redis RedisTemplate and such libraries, it is inefficient to configure a new RedisClient, even if we do so using some of the configuration from a configured LettuceConnectionFactory. Exposing the RedisClient created and used by LettuceConnectionFactory simplifies code and utilizes resources more efficiently.

 

---

Affects: 2.2.8 (Moore SR8)

3 votes, 4 watchers

[spring-projects-issues]

Mark Paluch commented

We could expose `AbstractRedisClient getRedisClient(). The client instance can be either RedisClientorRedisClusterClient`

[spring-projects-issues]

Ramsey Lubbat commented

That would work, thanks!