#75 - Add support for MySQL using jasync-mysql #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymous indexed bind markers come with a static placeholder symbol for all parameter occurrences and they are bound by index.
We now support MySQL through the jasync-mysql driver that exposes its asynchronous functionality through a R2DBC wrapper implementation. Jasync uses for now its own exceptions.
Unify connection creation by providing JDBC URL. Obtain R2DBC ConnectionFactory using connection factory discovery.
schauder
pushed a commit
that referenced
this pull request
Apr 17, 2019
Anonymous indexed bind markers come with a static placeholder symbol for all parameter occurrences and they are bound by index. Original pull request: #84.
schauder
pushed a commit
that referenced
this pull request
Apr 17, 2019
We now support MySQL through the jasync-mysql driver that exposes its asynchronous functionality through a R2DBC wrapper implementation. Jasync uses for now its own exceptions. Original pull request: #84.
schauder
pushed a commit
that referenced
this pull request
Apr 17, 2019
Unify connection creation by providing JDBC URL. Obtain R2DBC ConnectionFactory using connection factory discovery. Original pull request: #84.
schauder
added a commit
that referenced
this pull request
Apr 17, 2019
Clarified code a little. Added a warning to `AnonymousBindMarkers`: Anonymous bind markers are problematic because the have to appear in generated SQL in the same order they get generated. This might cause challenges in the future with complex generate statements. For example those containing subselects which limit the freedom of arranging bind markers. Original pull request: #84.
|
That is merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support MySQL through the jasync-mysql driver that exposes its asynchronous functionality through a R2DBC wrapper implementation.
Jasync uses for now its own exceptions. We also introduced support for anonymous bind markers which use ordinal binding an a static placeholder.
Related ticket: #75.