Introduced pessimistic locks for derived queries. #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods which use the derive query functionality now can be annotated with `@Lock` to used a given `LockMode`. Right now there are two different modes `PESSIMISTIC_READ` and `PESSIMISTIC_WRITE`. Based on the dialect the right select is generated. For example for H2 `Select ... FOR UPDATE`. Closes spring-projects/spring-data-relational#1041 Related tickets spring-projects#643
spring-projects-issues
added
the
status: waiting-for-triage
Closed
4 tasks
mp911de
added
the
status: blocked
|
Thanks a lot. It makes sense to have this, but we're in the process of moving Spring Data R2DBC into Spring Data Relational (side by side with JDBC) and we need to apply some refactoring in JDBC first before we can merge this one. |
No worries! In case you have questions about the locking implementation, I am glad to help, since I also implemented the same for spring-data-JDBC. |
schauder
added a commit
to spring-projects/spring-data-relational
that referenced
this pull request
Feb 22, 2022
This allows both Spring Data R2DBC and Spring Data JDBC to use the same annotation. See /issues/1041, spring-projects/spring-data-r2dbc/pull/720, /pull/1158
schauder
added a commit
to spring-projects/spring-data-relational
that referenced
this pull request
Feb 22, 2022
This allows both Spring Data R2DBC and Spring Data JDBC to use the same annotation. See /issues/1041, spring-projects/spring-data-r2dbc/pull/720, /pull/1158
schauder
added a commit
to spring-projects/spring-data-relational
that referenced
this pull request
Feb 22, 2022
See /issues/1041 Original pull request spring-projects/spring-data-r2dbc/pull/720
|
Thanks, that's merged polished and merged into 3.0.x |
schauder
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods which use the derive query functionality now can be annotated with
@Lockto used a givenLockMode. Right now there are two different modesPESSIMISTIC_READandPESSIMISTIC_WRITE. Based on the dialect the right select is generated. For example for H2Select ... FOR UPDATE.Closes spring-projects/spring-data-relational#1041
Related tickets #643