Skip to content

MSSQL: Using IsTrue or True in Query Method doesn't work on BIT columns #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

MSSQL: Using IsTrue or True in Query Method doesn't work on BIT columns #708

wants to merge 4 commits into from

Conversation

manousos
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2022
@manousos
Copy link
Contributor Author

Closes #698

@manousos manousos changed the title Issue/698 MSSQL: Using IsTrue or True in Query Method doesn't work on BIT columns Jan 15, 2022
@mp911de mp911de self-assigned this Jan 17, 2022
@mp911de mp911de added this to the 1.4.2 (2021.1.2) milestone Jan 17, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 17, 2022
mp911de pushed a commit that referenced this pull request Jan 17, 2022
@manousos @mp911de
Fix isTrue/isFalse comparison for SQL server by using bind values.
403ae58 
Closes: #698
Original pull request: #708.
mp911de added a commit that referenced this pull request Jan 17, 2022
@mp911de
Polishing.
bc861e6 
Reformat code. Add author tags.

See: #698
Original pull request: #708.
mp911de pushed a commit that referenced this pull request Jan 17, 2022
@manousos @mp911de
Fix isTrue/isFalse comparison for SQL server by using bind values.
a5206e4 
Closes: #698
Original pull request: #708.
mp911de added a commit that referenced this pull request Jan 17, 2022
@mp911de
Polishing.
6a43de0 
Reformat code. Add author tags.

See: #698
Original pull request: #708.
mp911de pushed a commit that referenced this pull request Jan 17, 2022
@manousos @mp911de
Fix isTrue/isFalse comparison for SQL server by using bind values.
b67359d 
Closes: #698
Original pull request: #708.
mp911de added a commit that referenced this pull request Jan 17, 2022
@mp911de
Polishing.
1cd5bc8 
Reformat code. Add author tags.

See: #698
Original pull request: #708.
@mp911de
Copy link
Member

mp911de commented Jan 17, 2022

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
1.4.2 (2021.1.2)
Development

Successfully merging this pull request may close these issues.
3 participants
@manousos @mp911de @spring-projects-issues