Reuse Dialect support provided by Spring Data Relational #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now reuse the existing Dialect infrastructure provided by Spring Data Relational to enhance it for R2DBC specifics such as bind markers.
schauder
pushed a commit
that referenced
this pull request
May 22, 2019
We now reuse the existing Dialect infrastructure provided by Spring Data Relational to enhance it for R2DBC specifics such as bind markers. Original pull request: #125.
schauder
pushed a commit
that referenced
this pull request
May 22, 2019
Original pull request: #125.
schauder
pushed a commit
that referenced
this pull request
May 22, 2019
Original pull request: #125.
schauder
added a commit
that referenced
this pull request
May 22, 2019
Minor changes to documentation in order to avoid <literal code>``s constructs as recommended by our style guide. Original pull request: #125.
|
That's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now reuse the existing Dialect infrastructure provided by Spring Data Relational to enhance it for R2DBC specifics such as bind markers. This allows us to provide only the R2DBC-specific extensions through
R2dbcDialect. We entirely rely on the provided rendering infrastructure and can remove our own tweaks.Related ticket: #55.