Skip to content

Document optimistic locking using @Version #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eiswind opened this issue Jul 27, 2020 · 5 comments
Closed

Document optimistic locking using @Version #418

eiswind opened this issue Jul 27, 2020 · 5 comments
Labels
type: documentation A documentation update
Milestone
1.1.3 (Neumann SR3)

Comments

@eiswind
Copy link

eiswind commented Jul 27, 2020

data-jdbc has this nice Feature, and it would be great if we could see this in r2dbc too.

I found that @Version is supported in
#93

Having user generated Ids is somewhat cumbersome, because according to the docs one needs to implements Persistable.
Considering version 0 to be new appears quite elegant.
@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Jul 28, 2020
@mp911de
Copy link
Member

mp911de commented Jul 28, 2020

That's already supported since version 1.1. Feel free to file a bug report in case @Version isn't working as advertised.

@eiswind
Copy link
Author

eiswind commented Jul 29, 2020

Sorry I didn't see that. Should have looked into the source.
Could it be that it's not in the docs? I also didn't see how immutable entities are handled on version update.

@mp911de
Copy link
Member

mp911de commented Jul 29, 2020

Good catch, we need to update the documentation.

@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 29, 2020
@mp911de mp911de changed the title Entity with uninitialized @Version property could be considered new Document optimistic locking using @Version Jul 29, 2020
@mp911de mp911de added this to the 1.1.3 (Neumann SR3) milestone Jul 29, 2020
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#418 - Document optimistic locking using @Version.
a0dc6f1
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#418 - Polishing.
bc2e977 
Fix fluent API documentation headers.
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#418 - Document optimistic locking using @Version.
c751310
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#418 - Polishing.
1298d1e 
Fix fluent API documentation headers.
@mp911de
Copy link
Member

mp911de commented Aug 4, 2020

That's done now.

@mp911de mp911de closed this as completed Aug 4, 2020
@eiswind
Copy link
Author

eiswind commented Aug 7, 2020

Thx for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
1.1.3 (Neumann SR3)
Development

No branches or pull requests
2 participants
@mp911de @eiswind