issue/element id #2718
Closed
issue/element id #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-simons
commented
May 3, 2023
•
michael-simons
commented
- prepare branch
- retarget id calls
- Remove elementid class without replacement
- wip
- more progress
- sometime I'm not gonna forget to not commit this.
- fix more things.
- reactive
- wip
- looking better…
- close
- mostly working
- moar work.
- imperative done
- reactive done
- You have read the Spring Data Neo4j contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
We never made use of it nor did we support it as public api in any shape or form.
meistermeier
requested changes
May 4, 2023
| @@ -52,23 +52,22 @@ private IdentitySupport() { | |||
| * @param propertyAccessor An accessor to the entity | |||
| * @param entity As received via the driver | |||
| */ | |||
| public static void updateInternalId(Neo4jPersistentEntity<?> entityMetaData, | |||
| public static void updateElementId(Neo4jPersistentEntity<?> entityMetaData, | |||
There was a problem hiding this comment.
I cannot spot any usage of this.
| } | ||
| } | ||
|
|
||
| static <T> String notAGoodNameSoFar( |
There was a problem hiding this comment.
better than having nothing 😸
| } else if (actualRelatedId == null) { | ||
| long internalId = databaseEntity.map(Entity::id).orElseThrow(); | ||
| propertyAccessor.setProperty(requiredIdProperty, internalId); | ||
| // relatedInternalId = Long.toString(internalId); |
| } finally { | ||
| lock.unlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Nullable | ||
| public Long getInternalId(Object object) { | ||
| public String getInternalId(Object object) { |
There was a problem hiding this comment.
Should we rename this to getObjectId or getElementId?
| import org.springframework.data.neo4j.test.BookmarkCapture; | ||
| import org.springframework.data.neo4j.test.Neo4jExtension; | ||
|
|
||
| abstract class AbstractTestBase { |
There was a problem hiding this comment.
Maybe call it AbstractElementIdTestBase?
|
Thanks @meistermeier for your review. Fixed all of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.