Skip to content

Optimise update of relationship properties #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meistermeier opened this issue Feb 9, 2023 · 0 comments
Closed

Optimise update of relationship properties #2668

meistermeier opened this issue Feb 9, 2023 · 0 comments
Assignees
@meistermeier
Milestone
6.3.8 (2021.2.8)

Comments

@meistermeier
Copy link
Collaborator

Currently the update query also fetches start and end node of the already existing relationship.
But we also know the exact id of the relationship and could just use this.
@meistermeier meistermeier added this to the 6.3.8 (2021.2.8) milestone Feb 9, 2023
@meistermeier meistermeier self-assigned this Feb 9, 2023
meistermeier added a commit that referenced this issue Feb 9, 2023
@meistermeier
GH-2668 - Optimise update of relationship properties.
ec5cb85 
There is no need to fetch start and end node if we already have the
identifier of the relationship to update.

Closes #2668
meistermeier added a commit that referenced this issue Feb 10, 2023
@meistermeier
GH-2668 - Optimise update of relationship properties.
93146df 
There is no need to fetch start and end node if we already have the
identifier of the relationship to update.

Closes #2668
@michael-simons michael-simons mentioned this issue Mar 31, 2023
Closed
michael-simons added a commit that referenced this issue Mar 31, 2023
@michael-simons
GH-2704 - Always define __relationships__ parameter.
fa1e469 
In #2668 storing of relationships has been optimised so that existing relationships are not always refetched. The new query always requires `__relationships__` to be present. In the case of relationships with defined properties, `Neo4jMappingContext#createStatementForRelationshipWithPropertiesBatch` only defines that argument for new relationships, so updating relationships with properties fails.

Closes #2704
michael-simons added a commit that referenced this issue Mar 31, 2023
@michael-simons
GH-2704 - Always define __relationships__ parameter.
410b60a 
In #2668 storing of relationships has been optimised so that existing relationships are not always refetched. The new query always requires `__relationships__` to be present. In the case of relationships with defined properties, `Neo4jMappingContext#createStatementForRelationshipWithPropertiesBatch` only defines that argument for new relationships, so updating relationships with properties fails.

Closes #2704
michael-simons added a commit that referenced this issue Mar 31, 2023
@michael-simons
GH-2704 - Always define __relationships__ parameter.
c31bd5d 
In #2668 storing of relationships has been optimised so that existing relationships are not always refetched. The new query always requires `__relationships__` to be present. In the case of relationships with defined properties, `Neo4jMappingContext#createStatementForRelationshipWithPropertiesBatch` only defines that argument for new relationships, so updating relationships with properties fails.

Closes #2704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meistermeier meistermeier

Labels
None yet
Projects
None yet
Milestone
6.3.8 (2021.2.8)
Development

No branches or pull requests
1 participant
@meistermeier