Skip to content

Inheritance determination performance improvements #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meistermeier opened this issue Feb 23, 2022 · 6 comments
Closed

Inheritance determination performance improvements #2487

meistermeier opened this issue Feb 23, 2022 · 6 comments
Assignees
Labels
status: feedback-provided Feedback has been provided

Comments

@meistermeier
Copy link
Collaborator

(better title required)

@nikobonomi
Copy link

Hello there,

First of all, thanks you for accepting this challenge 😄 your work is very much appreciated

Just for keeping track I link the neo4j community issue: https://community.neo4j.com/t/spring-data-neo4j-performance-issues/51984

Right now I cant see any 6.2.3-GH-2487-SNAPSHOT available in the two repositories you have linked.
I looked up here: https://repo.spring.io/ui/native/snapshot/org/springframework/data/spring-data-neo4j/

And also maven thorws an error at me saying:
Could not find artifact org.springframework.data:spring-data-neo4j:pom:6.2.3-GH-2487-SNAPSHOT in spring-snapshots (https://repo.spring.io/snapshot)

@meistermeier
Copy link
Collaborator Author

Thanks ❤️ There seems something wrong with the build and release process of artifacts right now. Investigating.

meistermeier added a commit that referenced this issue Feb 24, 2022
@meistermeier
Copy link
Collaborator Author

It should be available now. 🎉

@nikobonomi
Copy link

Well, first try and it seems freaking faster ⚡!

Later today I will make some more tests, but I'm pretty sure that the issue is fixed, thanks man!

@meistermeier meistermeier added the status: waiting-for-feedback We need additional information before we can continue label Feb 28, 2022
@nikobonomi
Copy link

Hello there,

This weekend I have done some queries to test a bit the improvements.
I can say that the issue is fixed, the response is quite fast (event for the luke case in which there is a lot to parse).

So, a huge thanks for your work, you saved my project 🍾

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 28, 2022
@meistermeier
Copy link
Collaborator Author

Thanks for your feedback. Glad that it is working for you.
And of course thanks for reporting this in the forums. Everyone using inheritance will profit from the improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-provided Feedback has been provided
Projects
None yet
Development

No branches or pull requests

3 participants