Skip to content

Honor ignoreCase() from Sort.Order. #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pelletier197 opened this issue May 31, 2021 · 5 comments
Closed

Honor ignoreCase() from Sort.Order. #2274

pelletier197 opened this issue May 31, 2021 · 5 comments
Assignees
Labels
type: bug A general bug

Comments

@pelletier197
Copy link

In spring data neo4j 5, We used to be able to sort ignoring the case. This doesn't seem supported anymore

This is the old query that was created by spring-data-neo4j 5

MATCH (department:Department)
RETURN department ORDER BY toLower(department.name) ASC SKIP $sdnSkip LIMIT $sdnLimit

And now, with version 6

MATCH (department:Department) 
RETURN department ORDER BY department.name ASC SKIP $skip LIMIT $limit

Here is the Pageable I use.

PageRequest.of(0, 10, Sort.by(Sort.Order.by("department.name").ignoreCase()))
@michael-simons michael-simons self-assigned this Jun 1, 2021
@michael-simons michael-simons added this to the 6.0.10 (2020.0.10) milestone Jun 1, 2021
@michael-simons michael-simons added the type: bug A general bug label Jun 1, 2021
@michael-simons
Copy link
Collaborator

Thanks for your kind report. I can confirm this as a bug.

@michael-simons michael-simons changed the title Sorting ignore case not working Honor ignoreCase() from Sort.Order. Jun 1, 2021
michael-simons added a commit that referenced this issue Jun 1, 2021
michael-simons added a commit that referenced this issue Jun 1, 2021
@michael-simons
Copy link
Collaborator

This will be fixed in all version from 6.0.10 onwards. Thanks again.

@pelletier197
Copy link
Author

Thank you! Is there an announced release date yet for 6.0.10?

@michael-simons
Copy link
Collaborator

No worries.

Sadly there isn't yet one in the team calendar (https://calendar.spring.io). I'll ask in the next sync call.
Until then, are the Snapshot repos an option?

<repositories>
    <repository>
      <id>spring-milestones</id>
      <name>Spring Milestones</name>
      <url>https://repo.spring.io/milestone</url>
      <snapshots>
        <enabled>false</enabled>
      </snapshots>
    </repository>
    <repository>
      <id>spring-snapshots</id>
      <name>Spring Snapshots</name>
      <url>https://repo.spring.io/snapshot</url>
      <releases>
        <enabled>false</enabled>
      </releases>
    </repository>
  </repositories>

they will contain a 6.0.10-SNAPSHOT with the fix shortly.

@pelletier197
Copy link
Author

If SNAPSHOT is available, we can figure something out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants