-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refine createCollection(…)
documentation and explore CollectionOptions
customization
#4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I'd back port the documentation updates to maintenance branches.
@@ -188,7 +188,7 @@ It is possible to create custom annotations out of the provided ones. | |||
MongoDB Collection Info:: | |||
+ | |||
==== | |||
[source,java,indent=0,subs="verbatim,quotes",role="thrid"] | |||
[source,jsonc,indent=0,subs="verbatim,quotes",role="thrid"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have been json
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been intentionally because of the comments, see https://komkom.github.io/jsonc/ and https://changelog.com/news/jsonc-is-a-superset-of-json-which-supports-comments-6LwR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not listed in here https://gitlab.com/antora/antora-ui-default/-/raw/HEAD/src/js/vendor/highlight.bundle.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's stick with json
…r `CollectionOptions`. Original Pull Request: #4979
Closes #4978