Add config option for Decimal128 representation of numerics. #4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Mar 11, 2025
| @@ -154,11 +161,18 @@ public static class MongoConverterConfigurationAdapter { | |||
| private static final Set<Class<?>> JAVA_DRIVER_TIME_SIMPLE_TYPES = Set.of(LocalDate.class, LocalTime.class, LocalDateTime.class); | |||
|
|
|||
| private boolean useNativeDriverJavaTimeCodecs = false; | |||
| private String numericFormat; | |||
There was a problem hiding this comment.
sure, either that or a flag like the native driver codecs.
| private final List<Object> customConverters = new ArrayList<>(); | ||
|
|
||
| private final PropertyValueConversions internalValueConversion = PropertyValueConversions.simple(it -> {}); | ||
| private PropertyValueConversions propertyValueConversions = internalValueConversion; | ||
|
|
||
| { |
There was a problem hiding this comment.
Let's not introduce Environment lookups here. Ideally, Spring Boot is an entry point for these config values so that we can remain clear of any configuration concerns.
We now allow configuring the default representation for BigDecimal and BigInteger values, still defaulting to string. BigDecimal can be configured to use Decimal128 by default.
Refine documentation. Simplify NumberToNumberConverter. Replace Environment-based configuration with config API.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some of the statically configured conversions into more dynamic spot. This now allows to access environment and manual config options when registering numeric converters like those for
BigInteger&BigDecimal.Still a draft as this one might not be side effect free.
Closes: #3444