Skip to content

Fix conversion of regular expression targeting id properties in queries #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix conversion of regular expression targeting id properties in queries #4718

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Jun 10, 2024 •
edited
Loading

This commit fixes an issue where patterns targeting id properties might have been falsely converted into the properties type, turning a Pattern into its String representation.

Closes: #4674

@christophstrobl
Prepare issue branch.
1106a5a
@christophstrobl
Fix conversion of regular expression in queries.
72f19c6 
This commit fixes an issue where patterns targeting id properties might have been falsely converted into the properties type, turning a Pattern into it's string representation.
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Fix conversion of regular expression in queries.
fd13c12 
This commit fixes an issue where patterns targeting id properties might have been falsely converted into the properties type, turning a Pattern into it's string representation.

Closes #4674
Original pull request: #4718
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
b252da5 
Invert types to retain check to avoid double negation.

See #4674
Original pull request: #4718
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Fix conversion of regular expression in queries.
c49ee25 
This commit fixes an issue where patterns targeting id properties might have been falsely converted into the properties type, turning a Pattern into it's string representation.

Closes #4674
Original pull request: #4718
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
ad45069 
Invert types to retain check to avoid double negation.

See #4674
Original pull request: #4718
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Fix conversion of regular expression in queries.
03de6f0 
This commit fixes an issue where patterns targeting id properties might have been falsely converted into the properties type, turning a Pattern into it's string representation.

Closes #4674
Original pull request: #4718
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
3ad0924 
Invert types to retain check to avoid double negation.

See #4674
Original pull request: #4718
@mp911de mp911de added the type: bug A general bug label Jun 11, 2024
@mp911de mp911de added this to the 4.2.7 (2023.1.7) milestone Jun 11, 2024
@mp911de mp911de added type: regression A regression from a previous release and removed type: bug A general bug labels Jun 11, 2024
@mp911de
Copy link
Member

mp911de commented Jun 11, 2024

That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 11, 2024
@mp911de mp911de deleted the issue/4674 branch June 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
4.2.7 (2023.1.7)
Development

Successfully merging this pull request may close these issues.

Criteria.regex is converted to String when applying to ID fields
2 participants
@christophstrobl @mp911de