Add support for Value Expressions #4635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,7 +67,7 @@ public ParameterBindingContext(ValueProvider valueProvider, ExpressionParser exp | |||
| * @param expressionEvaluator | |||
| * @since 3.1 | |||
| */ | |||
| public ParameterBindingContext(ValueProvider valueProvider, SpELExpressionEvaluator expressionEvaluator) { | |||
| public ParameterBindingContext(ValueProvider valueProvider, ValueExpressionEvaluator expressionEvaluator) { | |||
There was a problem hiding this comment.
can we deprecate the current public method and delegate with limited functionality?
@Deprecated(since = "3.3")
public ParameterBindingContext(ValueProvider valueProvider, SpELExpressionEvaluator expressionEvaluator) {
this(valueProvider, (ValueExpressionEvaluator) expressionEvaluator::evaluate);
}
public ParameterBindingContext(ValueProvider valueProvider, ValueExpressionEvaluator expressionEvaluator) {
...Add deprecations, refine nullability arrangements.
christophstrobl
pushed a commit
that referenced
this pull request
Feb 13, 2024
Add deprecations, refine nullability arrangements. Original Pull Request: #4635
christophstrobl
added a commit
that referenced
this pull request
Feb 13, 2024
Reduce method visibility, Remove unused variable. Add test and move off deprecated code in test. Original Pull Request: #4635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4634