Skip to content

Initial support for reactive bulk operations. #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Initial support for reactive bulk operations. #4342

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Mar 23, 2023 •
edited
Loading

Closes: #2821

mp911de
mp911de reviewed Apr 14, 2023
View reviewed changes
...ngodb/src/main/java/org/springframework/data/mongodb/core/DefaultReactiveBulkOperations.java
});
} catch (RuntimeException ex) {

if (ex instanceof MongoBulkWriteException) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these even happen? Why not catch(MongoBulkWriteException e)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the operation is ordered, yes.
https://www.mongodb.com/docs/manual/reference/method/db.collection.bulkWrite/#error-handling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in reactive, errors are emitted as signals through the publisher (that's why I was wondering) and not through the synchronous calls and therefore, the error signal translation is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh - you're right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for confirming. I'm happy to handle that aspect during the merge.

mp911de pushed a commit that referenced this pull request Apr 14, 2023
@christophstrobl @mp911de
Add support for reactive bulk operations.
86dd81f 
Closes #2821
Original pull request: #4342
mp911de added a commit that referenced this pull request Apr 14, 2023
@mp911de
Polishing.
67bd722 
Extract common code into BulkOperationsSupport. Reorder methods. Add missing verifyComplete to tests.

See #2821
Original pull request: #4342
@mp911de mp911de added the type: enhancement A general enhancement label Apr 14, 2023
@mp911de mp911de added this to the 4.1 RC1 (2023.0.0) milestone Apr 14, 2023
@mp911de mp911de closed this Apr 14, 2023
@mp911de mp911de deleted the issue/2821 branch April 14, 2023 12:51
@christophstrobl christophstrobl mentioned this pull request May 8, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.1 RC1 (2023.0.0)
Development

Successfully merging this pull request may close these issues.

Add support for reactive bulk operations [DATAMONGO-1922]
2 participants
@christophstrobl @mp911de