Skip to content

Update ParameterBindingJsonReader #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update ParameterBindingJsonReader #4334

wants to merge 4 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Mar 20, 2023

Follow changes in MongoDB's json parsing and update $uuid and $date parsing.
Also favour Base64 over Base64Utils and remove its usage.
Make sure to return null when reading string representation for a parameter that resolves to an actual null value.

Closes: #3750
Closes: #4282 (Supersedes: #4283)

…xtendedJson

This commit makes sure to return null for a null parameter value avoiding a potential NPE when parsing data.
In doing so we can ensure object creation is done with the intended value that may or may not lead to a downstream error eg. when trying to create an ObjectId with a null hexString.

Closes: #4282
@christophstrobl christophstrobl changed the title Update UUID parsing in ParameterBindingJsonReader Update ParameterBindingJsonReader Mar 21, 2023
@mp911de mp911de added the type: bug A general bug label Apr 13, 2023
@mp911de mp911de added this to the 4.1 RC1 (2023.0.0) milestone Apr 13, 2023
@mp911de mp911de closed this Apr 13, 2023
mp911de pushed a commit that referenced this pull request Apr 13, 2023
Closes: #3750
Original pull request: #4334
mp911de pushed a commit that referenced this pull request Apr 13, 2023
See: #3750
Original pull request: #4334
mp911de pushed a commit that referenced this pull request Apr 13, 2023
…ExtendedJson`.

This commit makes sure to return null for a null parameter value avoiding a potential NPE when parsing data.
In doing so we can ensure object creation is done with the intended value that may or may not lead to a downstream error eg. when trying to create an ObjectId with a null hexString.

Closes: #4282
Original pull request: #4334
@mp911de mp911de deleted the issue/3750 branch April 13, 2023 09:35
mp911de pushed a commit that referenced this pull request Apr 13, 2023
…ExtendedJson`.

This commit makes sure to return null for a null parameter value avoiding a potential NPE when parsing data.
In doing so we can ensure object creation is done with the intended value that may or may not lead to a downstream error eg. when trying to create an ObjectId with a null hexString.

Closes: #4282
Original pull request: #4334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
2 participants