Fix field resolution for ExposedFieldsAggregationContext. #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the context is not relaxed and errors on unknown fields if multiple stages of nesting contexts happen.
mp911de
reviewed
Mar 15, 2023
| @@ -96,6 +96,25 @@ private FieldReference getReference(@Nullable Field field, String name) { | |||
| return exposedField; | |||
| } | |||
|
|
|||
| if(rootContext instanceof RelaxedTypeBasedAggregationOperationContext) { | |||
There was a problem hiding this comment.
How about rootContext.getReference(…)? Wouldn't that work as well?
There was a problem hiding this comment.
IIRC it broke one of the existing tests for _id field projection.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the context is not relaxed and errors on unknown fields if multiple stages of nesting contexts happen.
Closes: #3917