Skip to content

Fix usage of change stream option startAfter. #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix usage of change stream option startAfter. #4168

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

closes: #4167

@christophstrobl
Prepare issue branch.
5fdb0b6
@christophstrobl
Fix usage of change stream option startAfter.
74c8acd 
We now make sure to apply the token to startAfter method of the driver. Before this change it had been incorrectly applied to resumeAfter.
mp911de pushed a commit that referenced this pull request Sep 16, 2022
@christophstrobl @mp911de
Fix usage of change stream option startAfter.
da5f249 
We now make sure to apply the token to startAfter method of the driver. Before this change it had been incorrectly applied to resumeAfter.

Closes #4167.
Original pull request: #4168.
mp911de added a commit that referenced this pull request Sep 16, 2022
@mp911de
Polishing.
c9be849 
Reformat code.

See #4167.
Original pull request: #4168.
mp911de pushed a commit that referenced this pull request Sep 16, 2022
@christophstrobl @mp911de
Fix usage of change stream option startAfter.
fcd6187 
We now make sure to apply the token to startAfter method of the driver. Before this change it had been incorrectly applied to resumeAfter.

Closes #4167.
Original pull request: #4168.
mp911de added a commit that referenced this pull request Sep 16, 2022
@mp911de
Polishing.
c700e9d 
Reformat code.

See #4167.
Original pull request: #4168.
mp911de pushed a commit that referenced this pull request Sep 16, 2022
@christophstrobl @mp911de
Fix usage of change stream option startAfter.
38390d3 
We now make sure to apply the token to startAfter method of the driver. Before this change it had been incorrectly applied to resumeAfter.

Closes #4167.
Original pull request: #4168.
mp911de added a commit that referenced this pull request Sep 16, 2022
@mp911de
Polishing.
96b564e 
Reformat code.

See #4167.
Original pull request: #4168.
@mp911de mp911de added the type: bug A general bug label Sep 16, 2022
@mp911de mp911de added this to the 3.2.12 (2021.0.12) milestone Sep 16, 2022
@mp911de
Copy link
Member

mp911de commented Sep 16, 2022

That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 16, 2022
@mp911de mp911de deleted the issue/4167 branch September 16, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.3.7 (2021.1.7)
Development

Successfully merging this pull request may close these issues.

Change stream option startAfter not applied via reactive template.
2 participants
@christophstrobl @mp911de