Skip to content

Add collation for an index via @CompoundIndex and @Index annotations. #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add collation for an index via @CompoundIndex and @Index annotations. #4131

wants to merge 1 commit into from

Conversation

StefanTirea
Copy link
Contributor

Closes #3002, closes #4130

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Hi,
I recently wanted to use Collation with Spring Data and saw there is no support to implement it only with annotations for a specific field.
A use case would be to have an unique index which is case insensitive.
My PR adds support to use it with annotations (currently it is only possible programmatically).
I hope the implementation did not miss an obvious hurdle for this feature.

Still missing in this PR:

  • Proper documentation in @Index & @CompoundIndex (see TODO)

@pivotal-cla
Copy link

@StefanTirea Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2022
@pivotal-cla
Copy link

@StefanTirea Thank you for signing the Contributor License Agreement!

@christophstrobl christophstrobl self-assigned this Aug 22, 2022
christophstrobl pushed a commit that referenced this pull request Aug 25, 2022
christophstrobl added a commit that referenced this pull request Aug 25, 2022
Resolve collation from template expression & update issue references + Javadoc.

Original Pull Request: #4131
christophstrobl added a commit that referenced this pull request Aug 25, 2022
The Collation annotation mainly serves as a meta annotation that allows common access to retrieving collation values for annotated queries, aggregations, etc.

Original Pull Request: #4131
@christophstrobl
Copy link
Member

Thank you @StefanTirea! Merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
4 participants