Skip to content

Make ChangeStreamOptionsBuilder support startAtOperationTime #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tudormarc
Copy link

@tudormarc tudormarc commented May 31, 2022

Make ChangeStreamOptionsBuilder support startAtOperationTime

Closes #3460

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2022
@christophstrobl christophstrobl removed the status: waiting-for-triage An issue we've not yet triaged label Jun 13, 2022
@christophstrobl
Copy link
Member

Thanks for the PR!

@christophstrobl
Copy link
Member

After a closer look at the PR it seems the newly introduced methods/properties are never propagated to the driver. As @mp911de already mentioned, it is already possible to set startAtOperationTime via resumeAt. This is my bad, sorry - I should have taken a closer look upfront.
Nevertheless your PR helped us identify a glitch (#4167) in the existing reactive implementation which does apply the resume token for startAfter incorrectly to resumeAfter

@christophstrobl christophstrobl added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2022
@mp911de mp911de added status: duplicate A duplicate of another issue status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 16, 2022
@mp911de
Copy link
Member

mp911de commented Sep 16, 2022

Superseded by #4167

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 16, 2022
@mp911de mp911de closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-provided Feedback has been provided status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ChangeStreamOptionsBuilder support startAtOperationTime [DATAMONGO-2607]
4 participants